Look up MSA files relative to input fasta/yaml#500
Open
Emrys-Merlin wants to merge 1 commit intojwohlwend:mainfrom
Open
Look up MSA files relative to input fasta/yaml#500Emrys-Merlin wants to merge 1 commit intojwohlwend:mainfrom
Emrys-Merlin wants to merge 1 commit intojwohlwend:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, relative MSA lookups seem to work relative to the current working directory. I would like to propose a change in behavior where the MSA file is looked up relative to the directory of the input file. In this way, I do not need to update the input fasta/yaml if I run the model from a different directory. For me, this would make data exchange much easier, as I only need to preserve my directory layout for the exchange.
I understand that this is a change in the user interface and that there might be good reasons for the current behavior. As the code changes were rather minimal, I decided to go ahead an just open a PR. At the same time, I understand if further discussions are necessary. I am also completely open to the conclusion that this change proposal should be disregarded.
Example
Directory structure
fasta input
yaml input
Run command
or
I am happy to provide the MSA file. It seems to be too large to attach to the post.
Expected behavior
The prediction should work.
Observed behavior